Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

Remove sendRequests method #7

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Remove sendRequests method #7

merged 1 commit into from
Oct 26, 2015

Conversation

joelwurtz
Copy link
Member

Remove sendRequests method with new version of httplug contract

@@ -16,8 +16,7 @@
],
"require": {
"php": ">=5.5.0",
"php-http/httplug": "^1.0@dev",
"php-http/utils": "^0.1@dev",
"php-http/httplug": "^1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work, since it is not stable yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I am not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works because we have the minimum stability and prefere stable option in composer.json

@sagikazarmark
Copy link
Member

Integration tests PR merged, tests should run fine.

@joelwurtz
Copy link
Member Author

Is there a way to relaunch them ?

@sagikazarmark
Copy link
Member

Build restarted, but still failing. But shouldn't hhvm be added to allowed failures?

@sagikazarmark
Copy link
Member

Ah, it is. Then no problem.

sagikazarmark added a commit that referenced this pull request Oct 26, 2015
@sagikazarmark sagikazarmark merged commit 80e8203 into php-http:master Oct 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants