Initial import #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| * | ||
| * @param string $name | ||
| * | ||
| * @return mixed |
| * | ||
| * @param null|string|UriInterface $baseUri | ||
| * | ||
| * @throws HttpAdapterException If the base uri is invalid. |
There was a problem hiding this comment.
If it comes from the old package, I'm wrong... By reading the current implementation, this is an exception which comes from phly/http so it can't be an HttpAdapterException.
There was a problem hiding this comment.
So what's the prognosis? Should it be simply removed?
| * | ||
| * @return ResponseInterface[] | ||
| * | ||
| * @throws MultiHttpAdapterException If an error occurred when you don't provide the error callable. |
There was a problem hiding this comment.
If an error occured is enough since we can't pass a callable anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the initial import of interfaces and the following changes: