Always read size of chunksize if in MemoryStream #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dbu
reviewed
Feb 18, 2019
| public function __construct($body = "", $chunkSize = null) | ||
| private $chunkSize; | ||
|
|
||
| public function __construct($body = "", $chunkSize = 8192) |
There was a problem hiding this comment.
how did you determine this default? is there a way to figure out the system default instead of hardcoding it here? i guess 8kb is the norm for 64bit and 4096 for 32bit?
There was a problem hiding this comment.
Default value is the BUFSIZ C constant which depends on the compiler used, and there is no way to get it here.
When reading various streaming PHP librairies, 8192 was a widely value used for buffer, so decided to keep here.
There was a problem hiding this comment.
thanks for the explanation!
oh this is the spec and not the source. sorry i asked, for a test we don't need to overthink it anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix test for php 7.2 / 7.3, PHP seems now to respect fread length better since those version exists, which is misleading in our test since we try to read the default php buffer size (8192)