-
Notifications
You must be signed in to change notification settings - Fork 39
Add GitHub actions #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub actions #122
Conversation
Do we agree with the style changes in this PR? I just used symfony, minus the rule mentioned in #119 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with these style changes.
96025dc
to
209c486
Compare
whats up with travis-ci? |
I removed the travis config, so it won't build this branch (and master after merging). @dbu If you agree with the changes we can merge this PR and disable the required check for travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first time i see github workflow... quite verbose this thing, i quite liked the almost-bashscript thing of travis-ci :-(
but this looks correct to me, lets do these changes.
@@ -0,0 +1,337 @@ | |||
parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea to add phpstan! and i agree with recording the baseline rather than trying to fix all in here.
we should open an issue to look into this file and see what we can fix / mark things as intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
extensions: mbstring | ||
|
||
- name: Setup Problem Matchers for PHPUnit | ||
run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for my understanding: what does this line thing do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When tests fail, the output is parsed by GH actions and failures are listed separately from the build log. This helps parsing PHPUnit failures.
is this a new problem or general about php 7.4? https://github.com/php-http/message/pull/122/checks?check_run_id=367925137 |
What do you mean exactly? It's a successful check. |
when you open the "Run tests" bit, it is full of warnings:
|
Closes #119