Fix: composer.json - clue/stream-filter version #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clue/stream-filter version should update to 1.4.1. *Problem:* if you use "php-http/message" several time on a package it will call "clue/stream-filter" several time. On their previous version before 1.4.1 they didn't have the duplicate function checking. So, it will create same namespace several time. *Real Life Example:* "php-http/message" has been used in - (infusionsoft/php-sdk)[https://github.com/infusionsoft/infusionsoft-php] if you create several wordpress plugins with - infusionsoft/php-sdk and install all the plugins in same website then "php-http/message" will be called several time so the "clue/stream-filter". Which create error for using same namespace.
|
thanks! glad that you found whats wrong, it would have been quite puzzling to figure that out... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: if you use "php-http/message" several time in a package, it will call "clue/stream-filter" several time. On their previous version, before 1.4.1, they didn't have the duplicate function checking. So, it will create same namespace several time.
Real Life Example: "php-http/message" has been used in - infusionsoft/php-sdk
if you create several wordpress plugins with - infusionsoft/php-sdk and install all the plugins in same website then "php-http/message" will be called several time so the "clue/stream-filter". Which create error for using same namespace.