prepare release #131
Merged
prepare release #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagikazarmark can you help me with the phpstan here? i added a composer run to install the dev dependencies to get rid of all the errors about 3rd party classes being unknown, but according to the log, we then again run composer uninstalling the dev dependencies again. |
Closed
|
i merged this now, not touching the phpstan issues. there have been no code changes, i guess it is improved checks ithat uncover things we should be fixing, but that should not prevent us from tagging the release. |
|
Thank you! btw phpstan version should be definitely locked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #130