Add Client::getLastRequest

[soullivaneuh]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Related tickets	fixes #16
Documentation	php-http/documentation#213
License	MIT

What's in this PR?

Add getters for last response, exception and request.

Why?

Because @sagikazarmark asked for it. 😉

Example Usage

See the doc PR

Checklist

• Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
• Documentation pull request created (if not simply a bugfix)

[dbu]

i like the getLastRequest method. the others seem odd - they would return things that we set with addResponse or addException. i don't think we should have those methods. or is there a good use case for them?

[soullivaneuh]

or is there a good use case for them?

Well, not for me personally. Maybe @sagikazarmark cans explain it?

[sagikazarmark]

Because @sagikazarmark asked for it. 😉

I would like to....... 😝

Jokes aside: I can't recall the exact use case for those two (maybe I could have written a better issue description).

I can think of a case when you configure the MockClient outside of your test case (with some common input) and you can't access that input directly. In those cases these methods could be useful, not sure how valid this case is.

[soullivaneuh]

I can think of a case when you configure the MockClient outside of your test case

Maybe as a Symfony service for example? php-http/HttplugBundle#212

[soullivaneuh]

Conflicts resolved.

[sagikazarmark]

Hm, maybe. Can't decide whether it's good or bad, but I can't see any issues with having them. @dbu ?

[dbu]

i find them confusing because i don't see legit use cases for it. they can be added when somebody has an actual use case for them imho.

but i can life with them if you insist on having them ;-)

[sagikazarmark]

i like the getLastRequest method

Do you still think this is useful? Or should we just drop this (BTW sorry @soullivaneuh )

[dbu]

getlastrequest sounds more useful to me. you can check what the last request that has been sent contained, and make assertions on it and so on.

[soullivaneuh]

So do you want me to let only getLastRequest on this PR?

(BTW sorry @soullivaneuh )

Don't worry, not a big deal! 😉

[soullivaneuh]

I updated this PR.

Well, it looks @Nyholm merge the docs one too quickly, here is a correction: php-http/documentation#216

[dbu]

sorry, this went under... @soullivaneuh would you mind checking if the doc is now correct on this one as its merged?

[soullivaneuh]

@dbu The doc is good according to me.

Could we have a new release since all the PR are merged? :-)

[Nyholm]

I've reviewed the changes. I think it's alright to tag 1.1.0.

I have not been a part of the latest PRs so I leave it to other maintainer to do the tag.