Update react/dns to use v1 or v0 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Jul 29, 2019
dbu
requested changes
Jul 30, 2019
There was a problem hiding this comment.
thanks for looking into this.
i see that react/http-client has no stable release yet.
what exactly do you mean with version v0 in the PR title? do you mean v0.4 by that? (semver says that between 0.4 and 0.5 [which does not exist and likely never will, now that a 1.0 has been released] there might be BC breaks - composer won't install 0.5 when the constraint is ^0.4)
xabbuh
approved these changes
Jul 30, 2019
|
thanks a lot @nenad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Uses either the v1 or v0 of the
react/dnspackage, depending on constraints.Why?
Allows projects to update dependencies that depend on
react/dnsto newer versions.Checklist
To Do