Skip to content

Replaced factory with loop::get() as factory depreciated. #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 20, 2021
Merged

Replaced factory with loop::get() as factory depreciated. #48

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e3ddf59
As of v1.2 eventloop:factory is depreciated.
tolgaulas Oct 19, 2021
3123eb2
changelog
tolgaulas Oct 19, 2021
6e44c3b
added cancel function in accordance to the php-http/promise interface PR
tolgaulas Oct 20, 2021
f853e7b
composer update with PR of php-http/promise
tolgaulas Oct 20, 2021
c427166
Update src/ReactFactory.php
tolgaulas Oct 20, 2021
e941318
Update composer.json
tolgaulas Oct 20, 2021
e67b69d
undo promise.cancel
tolgaulas Oct 20, 2021
99754df
promise.cancel removed
tolgaulas Oct 20, 2021
d7917f1
Apply suggestions from code review
dbu Oct 20, 2021
59ce34b
Update CHANGELOG.md
dbu Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Changed
## [3.0.1] - 2021-10-20

### Changed

- Replaced factory with loop::get() as factory depreciated.

## [3.0.0] - 2020-12-17

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"php": "^7.1|^8.0",
"php-http/httplug": "^2.0",
"react/http": "^1.0",
"react/event-loop": "^1.0",
"react/event-loop": "^1.2",
"php-http/discovery": "^1.0"
},
"require-dev": {
Expand Down
4 changes: 2 additions & 2 deletions src/ReactFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Http\Adapter\React;

use React\EventLoop\Factory as EventLoopFactory;
use React\EventLoop\Loop;
use React\EventLoop\LoopInterface;
use React\Http\Browser;
use React\Socket\ConnectorInterface;
Expand All @@ -19,7 +19,7 @@ class ReactFactory
*/
public static function buildEventLoop(): LoopInterface
{
return EventLoopFactory::create();
return Loop::get();
}

/**
Expand Down