Re-generated .h files after stubs were modified #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodabrew
reviewed
Dec 18, 2020
|
|
||
| ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0) | ||
| ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, persistent_id, IS_STRING, 1, "NULL") |
There was a problem hiding this comment.
I can't find a definition for this macro to understand why this fourth argument is changing from 1 to 0.
There was a problem hiding this comment.
It looks like it was incorrectly changed to 1 in 8f3c5dc#diff-25c321c509d1a97040fdc193f475a75a14a42492da840d7470bd609fbbe915ed. Probably they ran make using an old version of PHP 8.0. I generated this with 8.0.0.
sultan9900
reviewed
Dec 31, 2020
|
@sodabrew can we get a new tag for this? It's been a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #468.