ColourUtil tests and small refactors #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used
is_numeric
instead ofis_int
so we don't have to mix up types, we can just let php cast for us now, this allows us to keep parameter types and return types.fixed an issue with generating the colour set code when the bg colour hasn't been set yet
Added tests for
ColourUtil
Refactored
validateColour
to reduce nesting and return early