Skip to content

Refactor split item item selection and CliMenu can select checks. #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2018

Conversation

AydinHassan
Copy link
Member

Also add tests for split item menu.

Hey @Lynesth can you check this out please :)

@codecov-io
Copy link

codecov-io commented May 13, 2018

Codecov Report

Merging #138 into split-item-builder will increase coverage by 2.37%.
The diff coverage is 100%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             split-item-builder     #138      +/-   ##
========================================================
+ Coverage                 94.49%   96.87%   +2.37%     
- Complexity                  425      428       +3     
========================================================
  Files                        26       26              
  Lines                      1308     1311       +3     
========================================================
+ Hits                       1236     1270      +34     
+ Misses                       72       41      -31
Impacted Files Coverage Δ Complexity Δ
src/MenuItem/SplitItem.php 100% <100%> (ø) 41 <2> (+2) ⬆️
src/CliMenu.php 98.3% <100%> (+13.19%) 90 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b5927...d293834. Read the comment docs.

@AydinHassan AydinHassan merged commit 61c6940 into split-item-builder May 14, 2018
@AydinHassan AydinHassan deleted the split-item-select-refactor branch May 14, 2018 07:01
@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants