Skip to content

Remove the mandatory space after markers #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2018
Merged

Conversation

Lynesth
Copy link
Collaborator

@Lynesth Lynesth commented May 15, 2018

Needs #141 in order to work.

@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
@AydinHassan AydinHassan force-pushed the remove-marker-space branch from 1ccc78a to aeb48bc Compare May 17, 2018 09:40
@codecov-io
Copy link

codecov-io commented May 17, 2018

Codecov Report

Merging #154 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     97.69%   97.76%   +0.07%     
  Complexity      419      419              
============================================
  Files            25       25              
  Lines          1300     1300              
============================================
+ Hits           1270     1271       +1     
+ Misses           30       29       -1
Impacted Files Coverage Δ Complexity Δ
src/MenuStyle.php 96.99% <ø> (ø) 70 <0> (ø) ⬇️
src/MenuItem/SelectableTrait.php 100% <100%> (+3.84%) 9 <0> (ø) ⬇️
src/MenuItem/SplitItem.php 100% <100%> (ø) 42 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dae3f2...2b4c91d. Read the comment docs.

@AydinHassan AydinHassan merged commit 7d79121 into master May 17, 2018
@AydinHassan AydinHassan deleted the remove-marker-space branch May 17, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants