Skip to content

Selected item bugs #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2018
Merged

Selected item bugs #156

merged 1 commit into from
May 16, 2018

Conversation

AydinHassan
Copy link
Member

Few bugs related to the selected item:

  • If you add a non selectable item, then a selectable item after, nothing will be selected
  • Same with addItems
  • After set items with no selectable items, selectedItem might refer to a non existing item
  • If you remove the selected item, selectedItem is not updated and refers to a non existing item.

@codecov-io
Copy link

Codecov Report

Merging #156 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     97.82%   97.83%   +<.01%     
- Complexity      416      417       +1     
============================================
  Files            25       25              
  Lines          1289     1294       +5     
============================================
+ Hits           1261     1266       +5     
  Misses           28       28
Impacted Files Coverage Δ Complexity Δ
src/CliMenu.php 98.38% <100%> (+0.03%) 94 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2adaff...94c1df9. Read the comment docs.

Copy link
Collaborator

@Lynesth Lynesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AydinHassan AydinHassan merged commit 7dfdf75 into master May 16, 2018
@AydinHassan AydinHassan deleted the selected-item-bugs branch May 16, 2018 12:49
@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants