Skip to content

Fix infinite loop when no selectable items. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2018
Merged

Conversation

AydinHassan
Copy link
Member

Resolves #144 (hopefully)

@AydinHassan AydinHassan requested a review from Lynesth May 16, 2018 15:20
@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #159 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
+ Coverage     97.83%   97.84%   +<.01%     
- Complexity      417      418       +1     
============================================
  Files            25       25              
  Lines          1294     1298       +4     
============================================
+ Hits           1266     1270       +4     
  Misses           28       28
Impacted Files Coverage Δ Complexity Δ
src/CliMenu.php 98.4% <100%> (+0.02%) 95 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d01d834...1ca95cb. Read the comment docs.

Copy link
Collaborator

@Lynesth Lynesth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AydinHassan AydinHassan merged commit ab3b294 into master May 16, 2018
@AydinHassan AydinHassan deleted the fix-infinite-loop branch May 16, 2018 15:33
@AydinHassan AydinHassan added this to the 3.0 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants