Skip to content

Auto width docs #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2018
Merged

Auto width docs #164

merged 2 commits into from
May 22, 2018

Conversation

AydinHassan
Copy link
Member

@simonschaufi how is this?

@codecov-io
Copy link

codecov-io commented May 22, 2018

Codecov Report

Merging #164 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #164   +/-   ##
========================================
  Coverage      97.7%   97.7%           
  Complexity      419     419           
========================================
  Files            25      25           
  Lines          1306    1306           
========================================
  Hits           1276    1276           
  Misses           30      30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc045d4...e955747. Read the comment docs.

README.md Outdated
```

If you want to use the full width of the terminal and apply a margin you will need to perform a little calculation yourself
since we use a box model similar to CSS. The example below will use the full width of the terminal plus a margin of 2 on the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just mention what is included in the width and what not? It should be made clear that the margin is not included.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok. It is mentioned some lines before the changes: The width will include the padding and the border.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says above that the width includes the border and padding.

Copy link

@simonschaufi simonschaufi May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to CSS

better: like the box-sizing: border-box; in CSS

@AydinHassan AydinHassan merged commit dcd1df7 into master May 22, 2018
@AydinHassan AydinHassan deleted the auto-width-docs branch May 22, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants