-
Notifications
You must be signed in to change notification settings - Fork 106
Initial checkable item support #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial checkable item support #186
Conversation
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
===========================================
- Coverage 93.29% 93.19% -0.1%
- Complexity 460 486 +26
===========================================
Files 26 27 +1
Lines 1402 1470 +68
===========================================
+ Hits 1308 1370 +62
- Misses 94 100 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop item extra support from this item, I can't imagine it being very useful in this circumstance. What do you think?
Overall it looks great. I've left a few other comments to address, mostly regarding renaming a few things. But I'd say go ahead and add tests :)
/cc @mikeymike
Would prefer this be a separate PR. |
Pending unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great now apart from one comment.
LGTM! Thanks a lot @jtreminio |
edit: Ready for merging.
Related to #185