Switch screen functionality #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
============================================
+ Coverage 80.92% 81.41% +0.48%
- Complexity 80 82 +2
============================================
Files 7 7
Lines 152 156 +4
============================================
+ Hits 123 127 +4
Misses 29 29
Continue to review full report at Codecov.
|
|
@mikeymike I definitely prefer the approach in this PR - |
AydinHassan
approved these changes
Apr 23, 2018
There's 2 "screens" that I've called primary and secondary here Switching the screen allows doing things without impact the primary one vim and less use this which is why when you quit you have no evidance of it
mikeymike
force-pushed
the
switch-buffer
branch
from
7a98c26 to
78b2f18
Compare
|
hmm yes I like primary/secondary ... updated 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's 2 "screens" that I've called main and alternate here
Switching the screen allows doing things without impact the main one
vim and less use this which is why when you quit you have no evidance of it
I was debating about the api for this,
switchScreenand track internally or have two very specific methods and zero internal tracking. Let me know what you think