Catch all controls #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
============================================
+ Coverage 81.41% 81.64% +0.23%
- Complexity 82 83 +1
============================================
Files 7 7
Lines 156 158 +2
============================================
+ Hits 127 129 +2
Misses 29 29
Continue to review full report at Codecov.
|
mikeymike
approved these changes
Apr 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated so that
isControlwill return true for anything that is a control signal (hopefully) - basically ASCII characters 0-31 and 127.Also added a
isHandledControlthat returns true if it's a control and one we allow to handle ( we can update the list of handled ones whenever we want really - but I'd just leave it until we need them)