More clearing methods #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
===========================================
- Coverage 81.52% 80.5% -1.03%
- Complexity 82 83 +1
===========================================
Files 7 7
Lines 157 159 +2
===========================================
Hits 128 128
- Misses 29 31 +2
Continue to review full report at Codecov.
|
mikeymike
reviewed
May 1, 2018
src/UnixTerminal.php
Outdated
| /** | ||
| * Erase the entire current line | ||
| */ | ||
| public function clearEntireLine() : void |
There was a problem hiding this comment.
Would this just replace clear line, not sure what the difference is between the two
Maybe the current clear line only does from cursor to the right the same amount of cols as the width 🤔
There was a problem hiding this comment.
Yeah I wasn't sure - they definitely provide different functions like you describe, not sure whether both are needed. I guess there might be for other use cases ?
mikeymike
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For php-school/cli-menu#83