Skip to content

Added updates about member status changes in chats #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Added updates about member status changes in chats #1188

merged 1 commit into from
Mar 30, 2021

Conversation

massadm
Copy link

@massadm massadm commented Mar 16, 2021

? !
Type feature
BC Break no
Fixed issues #1186

Summary

As a starting point.

@noplanman noplanman changed the base branch from develop to bot_api_5.1 March 16, 2021 22:28
@noplanman
Copy link
Member

Hi @massadm, this is a great start, thank you!

I've changed the base branch to point to bot_api_5.1, where we can bring our work together.

Are you actively working on this or shall I go ahead to implement the rest on top of your work?

@massadm
Copy link
Author

massadm commented Mar 17, 2021

Are you actively working on this or shall I go ahead to implement the rest on top of your work?

Changes to the database will be required, so first I wanted to suggest adding DB migrations using phinx.

@noplanman
Copy link
Member

noplanman commented Mar 17, 2021

We aren't using Phinx at the moment, only SQL update scripts.
There is a proof-of-concept PR for Phinx but nothing has happened there yet.

I hope to get the changes for API 5.1 in this week!

@massadm
Copy link
Author

massadm commented Mar 18, 2021

We aren't using Phinx at the moment, only SQL update scripts.

OK, where to place SQL-updates for #1188?

I hope to get the changes for API 5.1 in this week!

What can I do?

I can add types and files to alter DB.

@noplanman
Copy link
Member

Have a look at this PR as an example for updates to the DB: https://github.com/php-telegram-bot/core/pull/1067/files

Files that will need changing are:

  • src/DB.php
  • structure.sql
  • utils/db-schema-update/0.71.0-unreleased.sql

I'll update the readme once we're ready to merge into develop 👍

For the future, you can also put everything into a single PR, which is easier for me to check and test 🙏

@massadm massadm marked this pull request as ready for review March 21, 2021 16:58
@noplanman noplanman merged commit ccb32d7 into php-telegram-bot:bot_api_5.1 Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants