Allow defining update types when handling updates via getUpdates method
#1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add extra parameter to define allowed types
noplanman
force-pushed
the
1201-allowed_updates-for-getupdates
branch
from
cdb8846 to
2c193f5
Compare
massadm
reviewed
Apr 7, 2021
|
@massadm I understand what you mean. The main reason I did it like this, is that only updates that are "known" by the library come through, to prevent any breakage in the future when new types get defined. I agree with you though, that the default behaviour should be what Telegram sends without specifying anything, will change this 👍 |
noplanman
changed the title
getUpdates methodgetUpdates method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an extra parameter to
Telegram::handleGetUpdatesto define allowed types. If no update types are passed, allow ALL update types, to make sure that special ones likechat_member(which MUST be defined to receive) also get fetched.