Skip to content

Add /whois command - old (see #150 for cleaner commits) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

jacklul
Copy link
Collaborator

@jacklul jacklul commented Apr 12, 2016

This command will allows to look up basic info about user/group stored in DB.
Chats command will display shortcuts to it instead of id (only if whois is available).

@jacklul
Copy link
Collaborator Author

jacklul commented Apr 13, 2016

Additionally optimized this and 'chats' a bit, it's better to just select one row instead of LOTS OF THEM and then iterating over them.

@noplanman
Copy link
Member

Cool, I really like this command! 👍
Would be great if /whois @noplanman or equivalent would work too, not only via ID 😊

I also saw that your new /chats command returns the link without a space after the command (e.g. /whois12345 instead of /whois 12345). Is this intentional? Both of those commands work for users though.
For groups it is /whoisg12345 that works, whereas /whois g12345 doesn't.

@jacklul
Copy link
Collaborator Author

jacklul commented Apr 14, 2016

I also saw that your new /chats command returns the link without a space after the command (e.g. /whois12345 instead of /whois 12345). Is this intentional?

Yes, so it can be clicked on /chats list.

For groups it is /whoisg12345 that works, whereas /whois g12345 doesn't.

That g is just a replacement for '-' and is only there so the command can be clicked.
/whois g12345 is not supposed to work, use /whois -12345 instead!

Would be great if /whois @noplanman or equivalent would work too, not only via ID

Good idea!

I don't want to spam the repo with so many commits from this PR, just say a word and I'll push all this changes to clean branch and make new PR for this!

@jacklul
Copy link
Collaborator Author

jacklul commented Apr 15, 2016

Cleaner branch commit: jacklul@28bd0f9

@jacklul jacklul closed this Apr 15, 2016
@jacklul jacklul mentioned this pull request Apr 15, 2016
@jacklul jacklul deleted the feature/whoisid branch April 15, 2016 22:22
@jacklul jacklul changed the title Add /whois command Add /whois command -old (see #150 for cleaner commits) Apr 16, 2016
@jacklul jacklul changed the title Add /whois command -old (see #150 for cleaner commits) Add /whois command - old (see #150 for cleaner commits) Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants