Skip to content

Commit 3322c78

Browse files
committed
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2: Fix #78623: Regression caused by "SP call yields additional empty result set"
2 parents 239e2dd + 114c03b commit 3322c78

File tree

5 files changed

+12
-2
lines changed

5 files changed

+12
-2
lines changed

NEWS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ PHP NEWS
3333
. Fixed bug #78272 (calling preg_match() before pcntl_fork() will freeze
3434
child process). (Nikita)
3535

36+
- PDO_MySQL:
37+
. Fixed bug #78623 (Regression caused by "SP call yields additional empty
38+
result set"). (cmb)
39+
3640
- Session:
3741
. Fixed bug #78624 (session_gc return value for user defined session
3842
handlers). (bshaffer)

ext/pdo_mysql/mysql_statement.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,14 +423,14 @@ static int pdo_mysql_stmt_next_rowset(pdo_stmt_t *stmt) /* {{{ */
423423
pdo_mysql_error_stmt(stmt);
424424
PDO_DBG_RETURN(0);
425425
} else {
426-
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt) && stmt->row_count);
426+
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt));
427427
}
428428
#else
429429
if (mysql_next_result(H->server) > 0) {
430430
pdo_mysql_error_stmt(stmt);
431431
PDO_DBG_RETURN(0);
432432
} else {
433-
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt) && stmt->row_count);
433+
PDO_DBG_RETURN(pdo_mysql_fill_stmt_from_result(stmt));
434434
}
435435
#endif
436436
}

ext/pdo_mysql/tests/bug_39858.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ if ($version < 50000)
1818
die(sprintf("skip Need MySQL Server 5.0.0+, found %d.%02d.%02d (%d)\n",
1919
$matches[0], $matches[1], $matches[2], $version));
2020
?>
21+
--XFAIL--
22+
nextRowset() problem with stored proc & emulation mode & mysqlnd
2123
--FILE--
2224
<?php
2325
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'mysql_pdo_test.inc');

ext/pdo_mysql/tests/bug_41997.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
PDO MySQL Bug #41997 (stored procedure call returning single rowset blocks future queries)
3+
--XFAIL--
4+
nextRowset() problem with stored proc & emulation mode & mysqlnd
35
--SKIPIF--
46
<?php
57
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'skipif.inc');

ext/pdo_mysql/tests/pdo_mysql_stmt_variable_columncount.phpt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
--TEST--
22
MySQL Prepared Statements and different column counts
3+
--XFAIL--
4+
nextRowset() problem with stored proc & emulation mode & mysqlnd
35
--SKIPIF--
46
<?php
57
require_once(dirname(__FILE__) . DIRECTORY_SEPARATOR . 'skipif.inc');

0 commit comments

Comments
 (0)