Skip to content

Commit b3f17ea

Browse files
committed
Promote invalid mode/unknow option from Warning to ValueError for plain streams.
Closes GH-5076
1 parent 2efa0b3 commit b3f17ea

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

main/streams/plain_wrapper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,7 +1029,7 @@ PHPAPI php_stream *_php_stream_fopen(const char *filename, const char *mode, zen
10291029

10301030
if (FAILURE == php_stream_parse_fopen_modes(mode, &open_flags)) {
10311031
if (options & REPORT_ERRORS) {
1032-
php_error_docref(NULL, E_WARNING, "`%s' is not a valid mode for fopen", mode);
1032+
zend_value_error("`%s' is not a valid mode for fopen", mode);
10331033
}
10341034
return NULL;
10351035
}
@@ -1464,7 +1464,7 @@ static int php_plain_files_metadata(php_stream_wrapper *wrapper, const char *url
14641464
ret = VCWD_CHMOD(url, mode);
14651465
break;
14661466
default:
1467-
php_error_docref1(NULL, url, E_WARNING, "Unknown option %d for stream_metadata", option);
1467+
zend_value_error("Unknown option %d for stream_metadata", option);
14681468
return 0;
14691469
}
14701470
if (ret == -1) {

0 commit comments

Comments
 (0)