Promote some warnings from streams to errors. #5076
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
streams-warnings-to-errors
branch
from
3807b2c to
fdb34e1
Compare
Girgias
force-pushed
the
streams-warnings-to-errors
branch
from
fdb34e1 to
b50636f
Compare
nikic
approved these changes
Feb 4, 2020
Girgias
commented
Feb 4, 2020
| @@ -1561,6 +1561,7 @@ PHPAPI php_stream *_php_stream_fopen_with_path(const char *filename, const char | |||
| *(cwd+3) = '\0'; | |||
|
|
|||
| if (snprintf(trypath, MAXPATHLEN, "%s%s", cwd, filename) >= MAXPATHLEN) { | |||
| /* Raise to warning? */ | |||
There was a problem hiding this comment.
@nikic Should I remove those comments or promote the notices to warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just seeing which tests need fixing with CI help
Edit: apparently none