Add Drupal to community build #10050
Conversation
andypost
force-pushed
the
9992-drupal
branch
2 times, most recently
from
63d9a29 to
1ecbb16
Compare
|
Looks to run kernel tests it needs |
|
debugging on unit and build tests as they are fast, as all databases available using to test sqlite/mysql/pgsql connections sqlite |
.github/workflows/push.yml
Outdated
| -d opcache.jit_buffer_size=16M | ||
| - name: Verify generated files are up to date | ||
| uses: ./.github/actions/verify-generated-files | ||
| - name: Test Drupal |
There was a problem hiding this comment.
You should move this to a new job for testing analogous to #9942. The binary needs to be built with the sanitize flags for this to be meaningful.
There was a problem hiding this comment.
Yes,I will
ATM trying to connect to pgsql but it looks broken
There was a problem hiding this comment.
I would just add another service like here: https://github.com/php/php-src/blob/master/.github/workflows/nightly.yml#L130-L137
There was a problem hiding this comment.
Or just use the existing mysql db if you can.
There was a problem hiding this comment.
Somehow pgsql connection has issues, I limited tests to sqlite and mysql now
andypost
force-pushed
the
9992-drupal
branch
11 times, most recently
from
bcf45df to
a60b38d
Compare
andypost
force-pushed
the
9992-drupal
branch
12 times, most recently
from
dc76130 to
1bc2eba
Compare
| if: always() | ||
| run: | | ||
| php -i|grep memory_limit | ||
| echo memory_limit=256M > /etc/php.d/drupal.ini |
There was a problem hiding this comment.
This should be done in setup, as it will leak into the next step anyway. Increasing the memory limit generally should be ok.
There was a problem hiding this comment.
Maybe this change could go separate file which will be removed at the end of script?
| cd drupal | ||
| git rev-parse HEAD | ||
| php /usr/bin/composer install --no-progress --ignore-platform-reqs | ||
| export ASAN_OPTIONS=exitcode=139 |
There was a problem hiding this comment.
Not your fault, but we could make ASAN_OPTIONS a global env var as it's always the same anyway.
There was a problem hiding this comment.
Gonna file separate PR for that
| mkdir db | ||
| rm -f core/tests/Drupal/FunctionalTests/ExistingDrupal8StyleDatabaseConnectionInSettingsPhpTest.php | ||
| export DRUPAL_TYPES=Annotation,Assertion,ClassFinder,Drupal,Extension,File,Plugin,Render,tar,zip | ||
| php -dzend.assertions=1 vendor/bin/phpunit -c core/phpunit.xml.dist --testsuite unit,kernel --group $DRUPAL_TYPES || exit 1 |
There was a problem hiding this comment.
Is there a point to adding assertions? I'm not against it, but we if we do we should do so for all projects. Generally, we're not interested in correct behavior, just crashes/memory violations.
There was a problem hiding this comment.
The point is that lots of tests require assertions to throw so php-unit can separate errors in data-providers
There was a problem hiding this comment.
I used to pick the most important test groups and database connectors, my next goal is to add a benchmark like WP and SF has
run kernel and unit tests for pdo_sqlite and pdo_mysql
Closes #9992