Fix GH-10519: Array Data Address Reference Issue #10749
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| --TEST-- | ||
| Bug #42654 (RecursiveIteratorIterator modifies only part of leaves) | ||
| --FILE-- | ||
| <?php | ||
| $data = array ('key1' => 'val1', array('key2' => 'val2'), 'key3' => 'val3'); | ||
|
|
||
| $iterator = new RecursiveIteratorIterator(new RecursiveArrayIterator($data)); | ||
| foreach($iterator as $foo) { | ||
| $key = $iterator->key(); | ||
| switch($key) { | ||
| case 'key1': // first level | ||
| case 'key2': // recursive level | ||
| echo "update $key".PHP_EOL; | ||
| $iterator->offsetSet($key, 'alter'); | ||
| } | ||
| } | ||
| $copy = $iterator->getArrayCopy(); | ||
| var_dump($copy); | ||
| ?> | ||
| --EXPECT-- | ||
| update key1 | ||
| update key2 | ||
| array(3) { | ||
| ["key1"]=> | ||
| string(5) "alter" | ||
| [0]=> | ||
| array(1) { | ||
| ["key2"]=> | ||
| string(5) "alter" | ||
| } | ||
| ["key3"]=> | ||
| string(4) "val3" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| --TEST-- | ||
| Bug GH-10519 (Array Data Address Reference Issue) | ||
| --FILE-- | ||
| <?php | ||
| interface DataInterface extends JsonSerializable, RecursiveIterator, Iterator | ||
| { | ||
| public static function init(Traversable $data): DataInterface; | ||
| } | ||
|
|
||
| class A extends RecursiveArrayIterator implements DataInterface | ||
| { | ||
| public function __construct($data) | ||
| { | ||
| parent::__construct($data); | ||
| } | ||
|
|
||
| public static function init($data): DataInterface | ||
| { | ||
| return new static($data); | ||
| } | ||
|
|
||
| public function getCols(string $colname): array | ||
| { | ||
| return array_column($this->getArrayCopy(), $colname); | ||
| } | ||
|
|
||
| public function bugySetMethod($key, $value) | ||
| { | ||
| $data = &$this; | ||
|
|
||
| while ($data->hasChildren()) { | ||
| $data = $data->getChildren(); | ||
| } | ||
| $data->offsetSet($key, $value); | ||
| } | ||
|
|
||
| public function jsonSerialize(): mixed | ||
| { | ||
| return $this; | ||
| } | ||
| } | ||
|
|
||
| $a = [ | ||
| 'test' => [ | ||
| 'a' => (object) [2 => '',3 => '',4 => ''], | ||
| ] | ||
| ]; | ||
|
|
||
| $example = A::init($a); | ||
| $example->bugySetMethod(5, 'in here'); | ||
| var_dump(json_encode($example)); | ||
| var_dump(json_encode($a)); | ||
|
|
||
| $b = [ | ||
| 'test' => [ | ||
| 'b' => [2 => '',3 => '',4 => ''], | ||
| ] | ||
| ]; | ||
| $example = A::init($b); | ||
|
|
||
| $example->bugySetMethod(5, 'must be here'); | ||
| var_dump(json_encode($example)); | ||
| var_dump(json_encode($b)); | ||
| ?> | ||
| --EXPECT-- | ||
| string(51) "{"test":{"a":{"2":"","3":"","4":"","5":"in here"}}}" | ||
| string(51) "{"test":{"a":{"2":"","3":"","4":"","5":"in here"}}}" | ||
| string(56) "{"test":{"b":{"2":"","3":"","4":"","5":"must be here"}}}" | ||
| string(37) "{"test":{"b":{"2":"","3":"","4":""}}}" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really confused by what's the point of this function is, staring at the usage.
Is this to detect if an SPLArray is a child and is refcounted?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I increased the
refcount+ 1 manually here and the assertionHT_ASSERT_RC1(ht)will failed.So I have to set the
refcountto 1 whenintern->is_childis true to make assertion success and restore therefcountto the original value after modifying thearray.