Fix RC1 assumption for typed properties with __get #10833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsetting typed properties resorts back to __get which may have RC1.
dstogov
reviewed
Mar 13, 2023
| @@ -3444,16 +3444,12 @@ static zend_always_inline int _zend_update_type_info( | |||
| } else if (ssa_op->op1_use >= 0 && !ssa->var_info[ssa_op->op1_use].is_instanceof) { | |||
| ce = ssa->var_info[ssa_op->op1_use].ce; | |||
| } | |||
| if (prop_info) { | |||
There was a problem hiding this comment.
If the problem is related to typed properties only, can we add a check for prop_info->type here?
There was a problem hiding this comment.
I checked, the problem is related not to typed property but any unset property. So the patch looks right.
There was a problem hiding this comment.
Yeah, sorry the comment is misleading. I'll adjust it.
dstogov
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsetting typed properties resorts back to __get which may have RC1.
Discovered using a debug flag to verify type inference I'm working on.