Skip to content

use_tls=0 on MSAN #10851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

use_tls=0 on MSAN #10851

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

Attempt to fix MSAN failure in CI

For context, we get regular failures in MSAN nightly builds with the same stacktrace, failing at __tls_get_addr. On master, since upgrading to Ubuntu 22.04 the MSAN build is completely broken. Add the use_tls=0 option in an attempt to avoid this issue.

========DIFF========
001+ MemorySanitizer:DEADLYSIGNAL
002+ ==179202==ERROR: MemorySanitizer: SEGV on unknown address (pc 0x7f73242b2bc0 bp 0x0000000000c0 sp 0x7ffe2810a3e8 T179202)
003+ ==179202==The signal is caused by a READ memory access.
004+ ==179202==Hint: this fault was caused by a dereference of a high value address (see register values below).  Dissassemble the provided pc to learn which register was used.
005+     #0 0x7f73242b2bc0  (/lib/x86_64-linux-gnu/libc.so.6+0x18bbc0)
006+     #1 0x65b59e in __msan::SetShadow(void const*, unsigned long, unsigned char) (/home/runner/work/php-src/php-src/sapi/cli/php+0x65b59e)
007+     #2 0x62a3ca in __tls_get_addr (/home/runner/work/php-src/php-src/sapi/cli/php+0x62a3ca)
008+     #3 0x7f7322c57ff3 in accel_globals_ctor /home/runner/work/php-src/php-src/ext/opcache/ZendAccelerator.c:2940:2
009+     #4 0x3a48f1c in tsrm_update_active_threads /home/runner/work/php-src/php-src/TSRM/TSRM.c:258:7
010+     #5 0x3a47d1a in ts_allocate_id /home/runner/work/php-src/php-src/TSRM/TSRM.c:299:2
001- <form action="//bad.net/do.php">
002- <fieldset>
003- <form action="//php.net/do.php"><input type="hidden" name="PHPSESSID" value="test021" />
004- <fieldset>
005- <form action="../do.php"><input type="hidden" name="PHPSESSID" value="test021" />
006- <fieldset>
007- <form action="/do.php"><input type="hidden" name="PHPSESSID" value="test021" />
008- <fieldset>
009- <form action="/foo/do.php"><input type="hidden" name="PHPSESSID" value="test021" />
010- <fieldset>
011+     #6 0x7f7322c4df79 in accel_startup /home/runner/work/php-src/php-src/ext/opcache/ZendAccelerator.c:3116:21
012+     #7 0x43b35bb in zend_extension_startup /home/runner/work/php-src/php-src/Zend/zend_extensions.c:196:7
013+     #8 0x4186e6c in zend_llist_apply_with_del /home/runner/work/php-src/php-src/Zend/zend_llist.c:171:7
014+     #9 0x43b3327 in zend_startup_extensions /home/runner/work/php-src/php-src/Zend/zend_extensions.c:217:2
015+     #10 0x3a6c1f5 in php_module_startup /home/runner/work/php-src/php-src/main/main.c:2263:2
016+     #11 0x55dcf76 in php_cli_startup /home/runner/work/php-src/php-src/sapi/cli/php_cli.c:410:9
017+     #12 0x55cfad2 in main /home/runner/work/php-src/php-src/sapi/cli/php_cli.c:1300:6
018+     #13 0x7f732414b082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082)
019+     #14 0x6013ad in _start (/home/runner/work/php-src/php-src/sapi/cli/php+0x6013ad)
020+ 
021+ MemorySanitizer can not provide additional info.
022+ SUMMARY: MemorySanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0x18bbc0) 
023+ ==179202==ABORTING
========DONE========
FAIL rewriter handles form and fieldset tags correctly [ext/session/tests/021.phpt] 

The changes in .github/workflows/push.yml will be reverted once merged.

Attempt to fix MSAN failure in CI
@iluuu1994 iluuu1994 closed this in 63525ee Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant