Gh 10168 alternative #11006
Closed
Gh 10168 alternative #11006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I don't know enough to comment much meaningful on this. But I tried to find some edge case variations and everything appears to work. I also checked with static analysers (PVS + my own tool) and it finds no bugs. |
iluuu1994
approved these changes
Apr 3, 2023
|
Just don't forget to add an entry in UPGRADING.INTERNALS when merging! |
|
@iluuu1994 could you please take care about adding the necessary UPGRADING.INTERNALS notes and merging this. |
|
This was merged into master. Thanks Dmitry for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10168
/cc @iluuu1994 @nielsdos