Implement DOMElement::toggleAttribute() #11696
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
force-pushed
the
dom-element-toggleAttribute
branch
2 times, most recently
from
540ea2b to
12c2081
Compare
|
I'm not 100% convinced yet all potential cases with |
|
Well that's probably good enough :D one can always report a bug if an edge case is found! |
nielsdos
force-pushed
the
dom-element-toggleAttribute
branch
from
12c2081 to
9f19055
Compare
|
Merged with some extra tests to cover additional combinations of the force argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://dom.spec.whatwg.org/#dom-element-toggleattribute