ODBC unit tests shouldn't override odbc.ini location #12133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ext/odbc/tests/config.inc` overrides the INIs used for the ODBC driver manager pointlessly. It's not pointing to some custom PHP test suite specific one, but the system one in `/etc/odbc(inst).ini`. Which doesn't necessarily exist, on i.e. NixOS, MacPorts, etc.
|
Nice! I recently had to find out how to run the test suite on a Mac, and I rather set up a symlink because I didn't know why etc/odbc.ini is needed. I'm glad that we can remove it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ext/odbc/tests/config.incoverrides the INIs used for the ODBC driver manager pointlessly. It's not pointing to some custom PHP test suite specific one, but the system one in/etc/odbc(inst).ini. Which doesn't necessarily exist, on i.e. NixOS, MacPorts, etc.Fixes running the test suite on macOS with MacPorts, which puts it in
/opt/local/etc.I'm applying this to 8.1 since it is a bug fix, but I can retarget if needed.