Fix the incorrect data type of float values in pdo_pgsql query results #12476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurunsoft
changed the title
devnexen
reviewed
Oct 19, 2023
|
Issue seems legit on the Windows CI instance otherwise. |
mvorisek
reviewed
Oct 20, 2023
|
Thanks, whenever you can please squash your commits into 1. |
Yurunsoft
force-pushed
the
pgsql-float
branch
from
03b6bee to
369efa8
Compare
Done. |
devnexen
approved these changes
Oct 20, 2023
|
As of 8.3 this code is still not merge, but it does exists in the master branch.
I ask because I am debating creating a custom fix for this (if this is scheduled for 8.4 release) or waiting a month it is available then (8.3.x release). |
|
At the time, PHP 8.3 already reached the feature freeze status, it will be present for 8.4 on november indeed. |
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Sep 9, 2024
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Sep 9, 2024
devnexen
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.