Skip to content

Use Clang 16 to work around LSAN TLS crashes #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2023
Merged

Use Clang 16 to work around LSAN TLS crashes #12496

merged 1 commit into from
Oct 22, 2023

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Oct 22, 2023 •
edited
Loading

Spun out from #12111

iluuu1994
iluuu1994 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we use the same approach for nightly with GCC? I'm not sure if older versions of GCC work with newer versions of libasan. I'd also be ok with switching to Clang on nightly, however the JIT is currently incompatible with UBSAN on Clang.

@nielsdos
Copy link
Member Author

LGTM, can we use the same approach for nightly with GCC?

Via a ppa yes. Do we actually run into this, or is the version used with gcc recent enough to not have the issue?

@iluuu1994
Copy link
Member

@nielsdos I'm not sure. There have been crashes due to dl() in the past that are skipped, along with some others that were fixed by upgrading the Ubuntu version. You could try triggering the nightly action from your fork to verify.

@nielsdos nielsdos merged commit 046d7f9 into php:master Oct 22, 2023
iluuu1994 pushed a commit to iluuu1994/php-src that referenced this pull request Jun 14, 2024
@nielsdos @iluuu1994
Use Clang 16 to work around LSAN TLS crashes (php#12496)
f999f09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@TimWolla TimWolla Awaiting requested review from TimWolla TimWolla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994