GH-12943 ext/intl accept C as acceptable locale argument. #12955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have approval authority, but it looks good. |
Girgias
approved these changes
Dec 16, 2023
Comment on lines
+8
to
+12
| $fmt = new IntlDateFormatter( | ||
| 'C', | ||
| IntlDateFormatter::FULL, | ||
| IntlDateFormatter::FULL, | ||
| ); |
There was a problem hiding this comment.
Nit: CS
Suggested change
| $fmt = new IntlDateFormatter( | |
| 'C', | |
| IntlDateFormatter::FULL, | |
| IntlDateFormatter::FULL, | |
| ); | |
| $fmt = new IntlDateFormatter( | |
| 'C', | |
| IntlDateFormatter::FULL, | |
| IntlDateFormatter::FULL, | |
| ); |
| @@ -112,7 +112,7 @@ static zend_result datefmt_ctor(INTERNAL_FUNCTION_PARAMETERS, zend_error_handlin | |||
| } | |||
| locale = Locale::createFromName(locale_str); | |||
| /* get*Name accessors being set does not preclude being bogus */ | |||
| if (locale.isBogus() || strlen(locale.getISO3Language()) == 0) { | |||
| if (locale.isBogus() || (strcmp("C", locale_str) && strlen(locale.getISO3Language()) == 0)) { | |||
There was a problem hiding this comment.
Suggested change
| if (locale.isBogus() || (strcmp("C", locale_str) && strlen(locale.getISO3Language()) == 0)) { | |
| if (locale.isBogus() || (locale_str == 1 && locale_str[0] == 'C') && strlen(locale.getISO3Language()) == 0)) { |
The call to strcmp() is not needed.
There was a problem hiding this comment.
I guess you meant locale_len == 1
devnexen
force-pushed
the
intl_accept_c
branch
from
6067f33 to
158dea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.