Skip to content

Fix DragonFly build #13085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix DragonFly build #13085

merged 1 commit into from
Jan 8, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jan 6, 2024

On DragonFly by default the BSD make is used with the CSH shell and the first prerequisite variable $< in Makefile doesn't work there. So, we can simplify this by simply repeating the filename here.

--- ext/opcache/jit/ir/gen_ir_fold_hash ---
cc -DIR_TARGET_X64 -DIR_PHP -DIR_PHP_MM=0 -o ext/opcache/jit/ir/gen_ir_fold_hash 
cc: fatal error: no input files
compilation terminated.
*** [ext/opcache/jit/ir/gen_ir_fold_hash] Error code 1

OS: DragonFly 6.4 and everything installed by default.

P.S.: The $< variable might work with patterns or in some other cases. And tests all pass ok so far.

On DragonFly by default the BSD make is used with the CSH shell and the
first prerequisite variable `$<` in Makefile doesn't work there. So, we
can simplify this by simply repeating the filename here.
@petk petk merged commit 6aad7a0 into php:master Jan 8, 2024
@petk petk deleted the patch-makefile branch January 8, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants