Fix linking ext/curl against OpenSSL #13262
Conversation
Following 68f6ab7, the ext/curl doesn't need to be linked against OpenSSL anymore, if curl_version_info_data ssl_version is OpenSSL/1.1 or later. With OpenSSL 3 and later the check for old SSL crypto locking callbacks was detected here. This also uses a common PHP_SETUP_OPENSSL macro for checking OpenSSL and syncs the minimum OpenSSL version (currently 1.0.2 or later) across the PHP build system.
petk
force-pushed
the
patch-openssl-min-version
branch
from
0f35b17 to
6536414
Compare
|
Edit: I've reworded the commit message in the last push to not mention when this check could potentially be removed since it depends on the curl minimum version. |
|
If @adoy is fine with this, I'll merge this in the following days. Probably the test program could be simplified even more here with some C-fu, but I'm not sure how to do that at this point and I think it's fine for now. |
|
I'd say since it s master if it needs further improvements, it can always be done later on. |
|
Looks good to me :) Thanks. Sorry about the late check but I don't have much time those days. |
|
I just came accross this when checking that we should disable the old version as locking should not be used on any supported OpenSSL library. This is actually a bug fix as the check incorrectly checks for OpenSSL 3+ so currently on 8.3 the locking is still being used which is wrong. 8.4 contains this so it just needs backport to 8.3. |
This is backport for 8.3 of b222c02 that originally targeted only 8.4+. This is however a bug fix. Following 68f6ab7, the ext/curl doesn't need to be linked against OpenSSL anymore, if curl_version_info_data ssl_version is OpenSSL/1.1 or later. With OpenSSL 3 and later the check for old SSL crypto locking callbacks was detected here. This also uses a common PHP_SETUP_OPENSSL macro for checking OpenSSL and syncs the minimum OpenSSL version (currently 1.0.2 or later) across the PHP build system.
|
Back ported in ae92b85 |
Following 68f6ab7, the ext/curl doesn't need to be linked against OpenSSL anymore, if curl_version_info_data ssl_version is OpenSSL/1.1 or later.
With OpenSSL 3 and later the check for old SSL crypto locking callbacks was detected here.
This also uses a common PHP_SETUP_OPENSSL macro for checking OpenSSL and syncs the minimum OpenSSL version (currently 1.0.2 or later) across the PHP build system.