Remove obsolete PHP_WITH_SHARED M4 macro #13374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
force-pushed
the
patch-autoconf-remove-php-with-shared
branch
from
24638bc to
25ac40d
Compare
petk
force-pushed
the
patch-autoconf-remove-php-with-shared
branch
from
25ac40d to
65c7600
Compare
This macro is obsolete in favor of the PHP_ARG_WITH macro. It was once used in combination with the AC_ARG_WITH macro to determine, whether the extension has been configured as shared.
petk
force-pushed
the
patch-autoconf-remove-php-with-shared
branch
from
65c7600 to
985a8a8
Compare
|
It seems macOS GitHub workflow got stuck somehow here. It's like some cache is in effect here and it fails rebuilding the dl_test object. I'll try reopening a new PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I'm not mistaken, this is obsolete in favor of the PHP_ARG_WITH macro. It was once used in combination with the AC_ARG_WITH macro to determine whether the extension has been configured as shared. 🤔