Skip to content

Remove unused config.w32.h.in symbols #13617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Mar 7, 2024

  • CONFIGURATION_FILE_PATH
    Removed via 2cf1b8d.

  • DISCARD_PATH
    Used for the --enable-discard-path CGI configure option and converted to INI configuration. Removed via 06f43b3.

  • HAVE_ERRMSG_H
    Removed via fd1578c.

  • HAVE_REGCOMP
    Used for regcomp function.

  • HAVE_RINT
    Used for rint function.

  • NEED_ISBLANK
    Windows ctype.h once didn't have C99 isblank() function. Cannot be found on current Windows systems anymore, neither was used in PHP at least since PHP 4.0.

  • PHP_URL_FOPEN
    Removed via cae2717.

  • REGEX
    Not used in current code.

  • HSREGEX
    Not used in current code.

  • USE_CONFIG_FILE
    Symbol was once defined by the --with-config-file-path configure option.

- CONFIGURATION_FILE_PATH
  Removed via 2cf1b8d.

- DISCARD_PATH
  Used for the --enable-discard-path CGI configure option and converted
  to INI configuration. Removed via
  06f43b3.

- HAVE_ERRMSG_H
  Removed via fd1578c.

- HAVE_REGCOMP
  Used for regcomp function.

- HAVE_RINT
  Used for rint function.

- NEED_ISBLANK
  Windows ctype.h once didn't have C99 isblank() function. Cannot be
  found on current Windows systems anymore, neither was used in PHP at
  least since PHP 4.0.

- PHP_URL_FOPEN
  Removed via cae2717.

- REGEX
  Not used in current code.

- HSREGEX
  Not used in current code.

- USE_CONFIG_FILE
  Symbol was once defined by the --with-config-file-path configure
  option.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@petk petk merged commit 713ac34 into php:master Mar 7, 2024
@petk petk deleted the patch-windows-config-h branch March 7, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants