Skip to content

Fix GH-13264: Part 1 - Memory leak on stream filter failure #13790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-13264: Part 1 - Memory leak on stream filter failure #13790

wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Mar 23, 2024

This fixes part of the issue GH-13264 which is the memory leak. That should be fairly safe to do and does not require changing the stream struct like the second part that will target just 8.3.

@bukka bukka mentioned this pull request Mar 23, 2024
Open
@bukka bukka changed the title Fix GH-13264: Part 1 - Memory leak on filter failure Fix GH-13264: Part 1 - Memory leak on stream filter failure Mar 23, 2024
nielsdos
nielsdos approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% familiar with streams but this is what I expected the fix to look like.

@bukka bukka closed this in c087398 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bukka @nielsdos