Skip to content

main/output.c: Refine int return type to bool or zend_result #13997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Apr 18, 2024

No description provided.

@Girgias Girgias force-pushed the output-refactoring branch from 723a628 to e166e6b Compare April 18, 2024 18:09
@Girgias Girgias marked this pull request as ready for review April 18, 2024 22:26
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, seems you went beyond than the commit message suggest :)

@Girgias Girgias merged commit 2447cb2 into php:master Apr 19, 2024
@Girgias Girgias deleted the output-refactoring branch April 19, 2024 09:46
@Girgias
Copy link
Member Author

Girgias commented Apr 19, 2024

Makes sense, seems you went beyond than the commit message suggest :)

The changes in iconv, tidy and zlib were needed because Windows/MSVC is more picky about function pointer type signatures matching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants