Replace configure option --with-openssl-dir #14028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a leftover from the refactoring of the --with-openssl-dir option that once accepted the path to OpenSSL but wasn't renamed back then. Instead of --with-openssl-dir, SSL support in ext/ftp and ext/mysqlnd can be enabled implicitly when building with ext/openssl enabled (--with-openssl) or explicitly by using new separate configure options --with-ftp-ssl and --with-mysqlnd-ssl.
github-actions
bot
added
Category: Build System
Extension: ftp
Extension: mysqlnd
labels
Girgias
approved these changes
Apr 23, 2024
Comment on lines
+105
to
+108
| - The configure option --with-openssl-dir has been removed. SSL support in | ||
| ext/ftp and ext/mysqlnd is enabled implicitly, when building with | ||
| ext/openssl (--with-openssl), or explicitly by using new configure options | ||
| --with-ftp-ssl and --with-mysqlnd-ssl. |
There was a problem hiding this comment.
The configure options are actually user facing changes that we need to document in manual
There was a problem hiding this comment.
Yes. PR to the doc-en coming up.
SakiTakamachi
approved these changes
Apr 27, 2024
|
As much as such new configure options are difficult to understand on the first glance, I'm not sure there is anything else to do. So merged to master then. I haven't added Windows options here due to different configuration there - it checks unconditionally for OpenSSL, which makes it simpler to configure PHP but also leaves out the user without info in case OpenSSL is not available. For now, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a leftover from the refactoring of the --with-openssl-dir option that once accepted the path to OpenSSL but wasn't renamed back then.
Instead of --with-openssl-dir, SSL support in ext/ftp and ext/mysqlnd can be enabled implicitly when building with ext/openssl enabled (--with-openssl) or explicitly by using new separate configure options --with-ftp-ssl and --with-mysqlnd-ssl.