Skip to content

Remove unused always-available extension headers #14042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2024

Conversation

petk
Copy link
Member

@petk petk commented Apr 24, 2024

These were once used in these files but at this point aren't and are only causing confusion whether file depends on additional extension.

@petk petk requested a review from bukka as a code owner April 24, 2024 21:04
@petk petk marked this pull request as draft April 24, 2024 21:36
@petk petk force-pushed the patch-ext-headers branch from 8257191 to 10b4961 Compare April 25, 2024 10:30
These were once used in these files but at this point aren't and are
only causing confusion whether file depends on additional extension.

- locale.h is added in main/SAPI.c for _ENABLE_PER_THREAD_LOCALE
@petk petk force-pushed the patch-ext-headers branch from 10b4961 to a119fd5 Compare April 25, 2024 20:53
@petk petk marked this pull request as ready for review April 25, 2024 20:54
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me

@petk petk merged commit 04c417a into php:master May 4, 2024
@petk petk deleted the patch-ext-headers branch May 4, 2024 19:06
@petk
Copy link
Member Author

petk commented May 4, 2024

Merged to master. I've rechecked it again and all looks ok. The <stdlib.h> is included via php.h and php_config.h. Not ideal and this probably should be enhanced further on, but main point here is for now to only omit including redundant dependencies of these ext headers around the php-src. It makes directory structure a bit easier to understand from the build system point of view. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants