Skip to content

Fix DOM property handler return types #14095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix DOM property handler return types #14095

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

Use zend_result instead of int

@kocsismate
Fix DOM property handler return types
2233515 
Use zend_result instead of int
@kocsismate kocsismate requested a review from nielsdos as a code owner April 30, 2024 21:23
@kocsismate
Copy link
Member Author

kocsismate commented Apr 30, 2024 •
edited
Loading

I didn't have capacity to test it -- but if it works, feel free to merge it, I have gone to sleep. 💤

@nielsdos
Copy link
Member

This should work, but I was already making the patch before I saw this 😅
My PR #14096 does a little more too, so I'll close this and go with my PR.
Thanks anyway.

@nielsdos nielsdos closed this Apr 30, 2024
@kocsismate kocsismate deleted the dom-fix-build branch May 1, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos is a code owner

Assignees
No one assigned
Labels
Extension: dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nielsdos