Fix memory leak if calling SoapServer::setClass() twice #14381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
May 30, 2024
ext/soap/soap.c
Outdated
| static void delete_argv(struct _soap_class *class) | ||
| { | ||
| if (class->argc) { | ||
| for (int i = 0; i < class->argc;i++) { |
There was a problem hiding this comment.
nit: just for the style space before the incrementation :)
There was a problem hiding this comment.
Indeed, and for master this should even become uint32_t, which I'll do next... (after CI passes and this is merged)
devnexen
approved these changes
May 30, 2024
nielsdos
force-pushed
the
soap-setclass-leak
branch
from
9cdd055 to
29afda7
Compare
Girgias
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.