Add --enable-phpdbg-debug option on Windows #14568
Conversation
|
Output of PHPDBG tests are not identical on Windows and Linux |
Ok, yes, something seems not correct here yet. Checking... |
This enables outputting additional debugging messages when running phpdbg for developing and troubleshooting phpdbg itself. Option was already added in Autotools and this adds it also to Windows build system.
|
I see, there is everything enabled with Edit: I've marked this as draft for now. Issue is that enabling this option outputs additional strings when running tests. As intended by the PHPDBG_DEBUG but this is not ideal for sure. I was even thinking to remove these options altogether and use PHP_DEBUG/ZEND_DEBUG as done for the entire php-src already. But in this case it would probably be very confusing for people to get additional strings when running the phpdbg. And tests could be adapted with |
Because additional info is printed when running tests, the --enable-phpdbg-debug option is excluded for --enable-snapshot-build if not provided explicitly.
|
Alright, this now works. |
|
LGTM now :) |
This enables outputting additional debugging messages when running phpdbg for developing and troubleshooting phpdbg itself. Option was already added in Autotools and this adds it also to Windows build system.