Skip to content

Wrap stack direction check in Zend M4 macro #14694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2024
Merged

Wrap stack direction check in Zend M4 macro #14694

merged 1 commit into from
Jun 28, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 27, 2024

No description provided.

@petk
Copy link
Member Author

petk commented Jun 28, 2024

Merge coming up here later today or so...

devnexen
devnexen approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but did you do it for "cleanliness" purpose ?

@petk
Copy link
Member Author

petk commented Jun 28, 2024

LGTM but did you do it for "cleanliness" purpose ?

For readability to declutter the ZEND_INIT macro.

@petk petk merged commit 1a5c411 into php:master Jun 28, 2024
11 checks passed
@petk petk deleted the patch-zend-m4-8 branch June 28, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen