Skip to content

Refactor ZEND_MM alignment check #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2024
Merged

Refactor ZEND_MM alignment check #14720

merged 1 commit into from
Jun 29, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jun 29, 2024

  • Check added into a separate M4 macro
  • AC_CACHE_CHECK used for running the test program with cache variable for optional edge-case overrides
  • Help texts updated
  • If check fails for some reason, the configure step emits error as also done in the Zend C code
  • Cross-compilation values updated with type casts as done in the current conftest file output

- Check added into a separate M4 macro
- AC_CACHE_CHECK used for running the test program with cache variable
  for optional edge-case overrides
- Help texts updated
- If check fails for some reason, the configure step emits error as
  also done in the Zend C code
- Cross-compilation values updated with type casts as done in the
  current conftest file output
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@petk petk merged commit ca3b248 into php:master Jun 29, 2024
11 checks passed
@petk petk deleted the patch-zend-m4 branch June 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants