Skip to content

Autotools: Sync PHP_ADD_MAKEFILE_FRAGMENT #14766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

Autotools: Sync PHP_ADD_MAKEFILE_FRAGMENT #14766

merged 1 commit into from
Jul 3, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 2, 2024

  • Macro help text updated for extensions and general usage
  • Arguments quoted
  • dnl removes redundant newlines in the generated configure script

@petk
Autotools: Sync PHP_ADD_MAKEFILE_FRAGMENT
1194c0b 
- Macro help text updated for extensions and general usage
- Arguments quoted
- dnl removes redundant newlines in the generated configure script
@petk petk requested review from dstogov, iluuu1994 and bukka as code owners July 2, 2024 05:12
devnexen
devnexen approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@petk petk merged commit dc7b67e into php:master Jul 3, 2024
11 checks passed
@petk petk deleted the patch-PHP_ADD_MAKEFILE_FRAGMENT branch July 3, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

@iluuu1994 iluuu1994 Awaiting requested review from iluuu1994

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Category: Build System Extension: json Extension: opcache SAPI: cgi SAPI: cli SAPI: fuzzer SAPI: litespeed SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen